refactor: fuse sidecar serverless platform#4816
Merged
cheyang merged 10 commits intofluid-cloudnative:masterfrom Mar 26, 2025
Merged
refactor: fuse sidecar serverless platform#4816cheyang merged 10 commits intofluid-cloudnative:masterfrom
cheyang merged 10 commits intofluid-cloudnative:masterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
…atform Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
…ction Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
TrafalgarZZZ
force-pushed
the
refactor/fuse_sidecar_serverless_platform
branch
from
eba7b49 to
f8b3f80
Compare
Member
Author
|
/hold |
1 similar comment
Member
Author
|
/hold |
fluid-e2e-bot
Bot
added
do-not-merge/hold
and removed
do-not-merge/work-in-progress
labels
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Member
Author
|
/test fluid-e2e |
Member
Author
|
/unhold |
cheyang
reviewed
Mar 26, 2025
Collaborator
|
Thank you for your great work. Please add developer doc in future PR. |
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Currently, Fluid webhook gets serverless platform from a specific label in Pod's metadata. The label's key is set by a env variable called
KEY_SERVERLESS_PLATFORM. This is not a great design because each time when we add a new serverless platform, we also need to change the Webhook'sMutatingWebhookConfigurationto register the webhook with a matchedobjectSelector. This makesMutatingWebhookConfigurationlonger.This PR refactors the logic about getting serverless platform. Fluid webhook now looks at the Pod's annotation to see if there's an special annotation called
serverless.fluid.io/platform.Other changes this PR made:
ServerlessPlatformKeywhich is defined from a env variable.Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews